Forward euler implementation in Common Lisp #607
Conversation
june128
added
the
Implementation
| (loop | ||
| with result = (make-array n :initial-element 1) | ||
| for i from 1 upto (1- n) do | ||
| (setf (svref result i) (- (svref result (1- i)) (* 3 (svref result (1- i)) timestep))) |
There was a problem hiding this comment.
I don't think this should be indented.
| with approximatep = t | ||
| with solution = 0 | ||
| for i from 0 upto (1- (length result)) do | ||
| (setf solution (exp (* (- 3) i timestep))) |
There was a problem hiding this comment.
Similar indentation question here.
There was a problem hiding this comment.
Hey @berquist, what is wrong with the indentation exactly? How many spaces should (setf ... be indented with?
There was a problem hiding this comment.
Sorry, I should learn to read. I disagree that it shouldn't be indented, because do introduces a code block, that reads different to the loop syntax
There was a problem hiding this comment.
It looks like you're getting indentation within the do section and I am not. When I use emacs -Q to remove all my customizations, the entire loop body is unindented.
In addition a very loose style guide (https://lisp-lang.org/style-guide/) plus reading somewhere else that it doesn't really matter that much, these are nitpicks that can be ignored.
There was a problem hiding this comment.
I just pressed tab on the code and found that it unindented the code. I apparently made the decision half a year ago that this would be easier to read. I don't really care that much now and it should still be fine, so I'll put the code back.
There was a problem hiding this comment.
Well now I've changed it.
This is stupid, just merge it.
A review is appreciated!